Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Kill() does not block Stats() #1454

Merged
merged 1 commit into from
Jul 23, 2016
Merged

Driver Kill() does not block Stats() #1454

merged 1 commit into from
Jul 23, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Jul 21, 2016

This PR makes it so Driver Kill() does not block Stats(). This prevent's the APIs and CLI from blocking during a long kill_timeout

defer r.taskLock.RUnlock()
runners := make([]*TaskRunner, 0, len(r.tasks))
for _, tr := range r.tasks {
runners = append(runners, tr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we know how many task runners we are going to return and not filtering them

runners := make([]*TaskRunner,len(r.tasks))
for i, tr := range r.tasks {
  runners[i] = tr
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r.tasks is a map

@diptanu
Copy link
Contributor

diptanu commented Jul 22, 2016

LGTM

@dadgar dadgar merged commit b5b2faf into master Jul 23, 2016
@dadgar dadgar deleted the b-blocking-stats branch July 23, 2016 00:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants